Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/sync_denoms_ini_files #264

Merged
merged 2 commits into from
Nov 7, 2023
Merged

feat/sync_denoms_ini_files #264

merged 2 commits into from
Nov 7, 2023

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Nov 6, 2023

  • Updated fetch_denoms script file to reuse markets parsing logic in AsyncClient.
  • Synchronized all denoms ini files with the new logic (mainnet, testnet and devnet)

…ynchronized all denom files after the changes
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (4a5aea9) 56.30% compared to head (04abec3) 56.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   56.30%   56.45%   +0.15%     
==========================================
  Files          17       17              
  Lines        2039     2037       -2     
  Branches      241      241              
==========================================
+ Hits         1148     1150       +2     
+ Misses        855      851       -4     
  Partials       36       36              
Files Coverage Δ
pyinjective/async_client.py 50.20% <100.00%> (+0.20%) ⬆️
pyinjective/utils/fetch_metadata.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinhphuctadang vinhphuctadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarmoa aarmoa merged commit 7911c53 into master Nov 7, 2023
11 of 12 checks passed
@aarmoa aarmoa deleted the feat/sync_denoms_ini_files branch November 7, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants